Feature/predictable server ids #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As opposed to previous similar attempts to achieve this, this PR:
|
acelaya
force-pushed
the
feature/predictable-server-ids
branch
from
e8b9a3e to
e786f9d
Compare
Preview environmenthttps://shlinkio.github.io/shlink-web-client/feature/predictable-server-ids/ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1361 +/- ##
===========================================
+ Coverage 79.11% 79.66% +0.54%
===========================================
Files 49 49
Lines 1264 1303 +39
Branches 242 245 +3
===========================================
+ Hits 1000 1038 +38
+ Misses 23 21 -2
- Partials 241 244 +3 ☔ View full report in Codecov by Sentry. |
acelaya
force-pushed
the
feature/predictable-server-ids
branch
from
5e95a7a to
b31949b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1360
Change logic while creating servers, so that the server ID is computed from the name+domain, instead of generating a random UUID.
For example, for
{ "name": "My cool server", domain: "https://example.com", ... }, the generated ID ismy-cool-server-example.com.If the ID is duplicated, we will append an auto-increment counter, starting with
1, until no ID collission happens.This ensures server URLs are predictable across environments, as long as names and domains are preserved. This is the case for environments where a
servers.jsonfile or env vars for a default server are provided.As a nice side effect, the new URLs are more human friendly, and we can finally get rid of the
uuiddependency without introducing breaking changes.Existing servers that were previously created with a UUID will continue working normally, as once the ID is generated, there's no special treatment applied to it and it is simply used as is.